Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a deployment authorization issue by moving Node.js setup from a composite workflow action to inline workflow steps. The composite action was creating its own token context that lacked proper deployment permissions. By setting up Node.js directly within the workflow, the correct OIDC token is inherited and used for npm publishing. An additional benefit is improved deployment performance by avoiding unnecessary browser dependency installations.
Key Changes:
- Replaced the
install-depscomposite action with inlinesetup-nodeandinstall-project-depssteps - Removed browser dependency installation (Chrome, Firefox, Xvfb) from deployment workflows
- Maintained consistency across all deployment and validation jobs using YAML anchors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
straker
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting up Node through a composite workflow does not inherit the environment from the host. Meaning it creates its own token which does not have the correct deployment authorization.
This patch moves setting up node internal with no more use of the composite action for deployment. Which, enables the correct token to be used. It has a side effect of also saving us time in deploy by not installing the browser dependencies that aren't needed for this workflow.
Closes: #4912