test: fix prototype integration test in dark mode#4937
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a flaky integration test that was failing in dark mode by explicitly setting the foreground text color to ensure consistent contrast testing regardless of system color preferences.
- Adds explicit
color: blackstyle to the test fixture div withdarkredbackground - Makes the color-contrast prototype integration test deterministic across light/dark system modes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
straker
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test case was failing when I ran it locally because it relied on the default text
colorhaving low contrast with adarkredbackground, which is true when the system color preference is light mode but not in dark mode. This updates the test to also pin the foreground color, making it agnostic to the system color mode.No QA required