test(object-is-loaded-matches): prevent test flakiness by allowing more time to load <object> data#4530
Merged
test(object-is-loaded-matches): prevent test flakiness by allowing more time to load <object> data#4530
Conversation
WilcoFiers
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test failures are happening because the test isn't allowing sufficient time for slower test scenarios (headed browsers in CI machines) to finish setting up test fixtures before testing against them.
I experimented with using
load/errorevents on the fixtures instead of a flat time, but this didn't work reliably; in the case where the browser renders fallback content, it fires theerrorevent before the fallback content is ready, at least in Chromium stable. I wanted to stick to a timebox for this so I settled for just increasing the time allotment instead.Closes: #4529