refactor: put isContext methods on axe.utils#4524
Merged
WilcoFiers merged 2 commits intodevelopfrom Jul 10, 2024
Merged
Conversation
straker
previously approved these changes
Jul 3, 2024
| assert.isFalse(isContextObject(Object.create({ exclude: 'string' }))); | ||
| }); | ||
|
|
||
| it('is true for an object with both `include` and `exclude`', () => { |
Contributor
There was a problem hiding this comment.
Is it a bug or a feature that you can have a context object with invalid values for either include or exclude as long as one is valid? For example {include: [], exclude: 1}. Testing it looks like it works without issues.
It might be nice to have a test for it, but I don't think it's a blocker to the pr.
straker
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had a couple scenarios where this code was getting copied over to other repos. For backward compat reasons that's going to need to stay, but at least if we have these methods on axe.utils we can prevent problems in the future if we change how context works.
No QA needed on this one.