ci: fix usage of deprecated artifact actions#4495
Merged
WilcoFiers merged 1 commit intodequelabs:developfrom Jun 7, 2024
hamirmahal:fix/usage-of-deprecated-artifact-actions
Merged
ci: fix usage of deprecated artifact actions#4495WilcoFiers merged 1 commit intodequelabs:developfrom hamirmahal:fix/usage-of-deprecated-artifact-actions
artifact actions#4495WilcoFiers merged 1 commit intodequelabs:developfrom
hamirmahal:fix/usage-of-deprecated-artifact-actions
Conversation
|
|
hamirmahal
commented
Jun 6, 2024
Comment on lines
-22
to
-23
| # v4 download seems to have some flakiness with the download of artifacts so pinning to v3 for now | ||
| # @see https://github.com/actions/download-artifact/issues/249 |
Contributor
Author
There was a problem hiding this comment.
actions/download-artifact#249 (comment) says
Since the fix was released ~3 months ago I haven't faced the timeout issue again, using v4. Also, the lack of activity in here implies that it was indeed fixed across the board IMHO
WilcoFiers
approved these changes
Jun 7, 2024
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM. Much appreciated @hamirmahal!
For the books: I reviewed this for security.
artifact actionsartifact actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<< Describe the changes >>
Closes: #4494.