revert(color-contrast): revert upgrade to colorjs.io v0.5.0 to work with prototype.js#4429
Conversation
dbjorge
previously requested changes
Apr 25, 2024
Contributor
dbjorge
left a comment
There was a problem hiding this comment.
Mostly LGTM, just notice one issue with the old code we're reverting back to.
Verified that this doesn't negatively impact bundle size and doesn't require any LICENSE-3RD-PARTY update.
dbjorge
reviewed
Apr 25, 2024
dbjorge
approved these changes
Apr 25, 2024
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts back the v0.4.3 code in
color.jsto handle colorjs.io not handling rad and turn values in hsl.I also decided to use core-js
Array.frompolyfill rather than our own internal one since I needed to bring it in outside of thepolyfill.jsfile and could then add it as an import and reuse it in both places.Closes: #4428