Merged
Conversation
Axe-core needs to include the copyright and licenses of third-party software. I also looked at preserving the copyright statements from third-party libraries where they are embedded. Unfortunately that will require us addressing the webpack issue due to which we pinned our ESBuild version. #4305 --------- Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
…de types (#4317) Updates VirtualNode's `props` initialization path to avoid reading properties that we know based on `nodeType` won't be present anyway. This should mitigate #4316 by avoiding reading the problematic `value` prop present on certain text nodes. I also cleaned up some missing test coverage in the impacted code. Closes: #4316
* fix(d.ts): RawNodesResult issues * Type tests * More * empty * Fixed feedback
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
d5e27c4 to
b8839aa
Compare
straker
commented
Feb 7, 2024
| }, | ||
| "devDependencies": { | ||
| "axe-core": "^4.6.2", | ||
| "chai": "^4.3.7", |
Contributor
Author
There was a problem hiding this comment.
We needed to get the test/examples passing but trying to cherry-pick #4296 failed with conflicts so we'll make the change manually and deal with the merge conflict when it merges back into develop
Contributor
|
reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.