Skip to content

chore(deps): remove make-dir#4196

Merged
straker merged 1 commit intodevelopfrom
remove-make-dir
Oct 16, 2023
Merged

chore(deps): remove make-dir#4196
straker merged 1 commit intodevelopfrom
remove-make-dir

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Oct 12, 2023

Saw in #4191 that we were going to update make-dir. Was wondering what we used it for and saw we only use it in one file (build/shared/create-file.js which in turn is used in our rule generation script to create all the files) and that we could just replace it with fs.mkdir with the recursive: true flag. Also simplified the file to use fs.promises instead of utils.promisify (all available since node 10.1).

@straker straker requested a review from a team as a code owner October 12, 2023 22:38
@straker straker changed the title chore: remove make-dir dependency chore(deps): remove make-dir dependency Oct 12, 2023
@straker straker changed the title chore(deps): remove make-dir dependency chore(deps): remove make-dir Oct 12, 2023
@straker straker merged commit 9c70f22 into develop Oct 16, 2023
@straker straker deleted the remove-make-dir branch October 16, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants