feat: Deprecate impact on checks, use rules instead#4114
Merged
WilcoFiers merged 3 commits intodevelopfrom Aug 1, 2023
Merged
Conversation
straker
approved these changes
Aug 1, 2023
straker
requested changes
Aug 1, 2023
Contributor
straker
left a comment
There was a problem hiding this comment.
Missing the following rules, which means the rule validator is not working / running?
aria-rolesaria-valid-attr-valuescope-attr-valid
straker
approved these changes
Aug 1, 2023
Contributor
straker
left a comment
There was a problem hiding this comment.
Turns out they were already updated (but my local branch was not)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact is now required on rules, rather than on checks. This makes impact on checks obsolete. As of axe-core 4.8, impact on checks is deprecated.
Closes: #4066