Conversation
… which have ancestors with sectioning roles
WilcoFiers
previously requested changes
Jul 26, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Can you add integration tests plz.
WilcoFiers
approved these changes
Jul 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
nativeScopeFilterselector only accounted for native elements and not elements with sectioning roles. Instead of adding sectioning roles to the selector, I decided to add the newroleoption to let the check look at the role of the element, which computes the implicit html role based on sectioning ancestors. That way our selectors can't become out-of-sync and cause issues in the future.I also deprecated the
nativeScopeFilteroption since we shouldn't be using it over theroleoption.Closes: #3943