fix(color-contrast): ignore zero width characters#4103
Merged
Conversation
WilcoFiers
previously requested changes
Jul 26, 2023
dbjorge
previously approved these changes
Aug 7, 2023
Contributor
dbjorge
left a comment
There was a problem hiding this comment.
Updated inline with a non-copyright-encumbered custom font per our discussion offline. Minor suggestion on one of the new comments, otherwise LGTM!
Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
dbjorge
approved these changes
Aug 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I grabbed the Affirm font from the provided website. I couldn't figure out how to generate a font that had 0 width characters so I hope it's OK for us to grab it for test purposes.
Closes: #3918