fix(access-name): get name from header elements#4097
Merged
WilcoFiers merged 7 commits intodevelopfrom Aug 8, 2023
Merged
Conversation
WilcoFiers
commented
Jul 20, 2023
| ></label> | ||
|
|
||
| <div> | ||
| <label> |
Contributor
Author
There was a problem hiding this comment.
This label does nothing, and fail24 is not tested by this rule; this is not the select-name rule.
straker
previously requested changes
Jul 24, 2023
WilcoFiers
commented
Aug 7, 2023
straker
approved these changes
Aug 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content of landmarks and other elements that have "name from author" should not be ignored when referenced by aria-labelledby or another label.
This is a bug, where axe was inconsistent with the accessible name spec. Specifically, step F:
Previously axe-core was only considering the first part of this sentence, and skipping name from author elements while following aria-labelledby and
<label>IDREFs. This was a problem on dialogs (as the issue reported), but had broader implications too. Notably, column and rowheaders in a table could not be referenced with aria-labelledby.That created a second problem; Elements with a value (like select and progressbar) should never use name from content. I had to add a condition in for that. I ended up testing the use of element values in names again. This improved a good bit, and so now only the value of progressbar still can't be relied on to give an accessible name.
Closes: #3752