fix(color-contrast): process non-rgb color functions#4092
Merged
WilcoFiers merged 4 commits intodevelopfrom Jul 27, 2023
Merged
fix(color-contrast): process non-rgb color functions#4092WilcoFiers merged 4 commits intodevelopfrom
WilcoFiers merged 4 commits intodevelopfrom
Conversation
straker
previously approved these changes
Jul 24, 2023
Contributor
straker
left a comment
There was a problem hiding this comment.
Just a minor thing (can merge if you'd like). Regex is complicated so a comment above will help clarify the purpose of the matching.
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Jul 24, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent color-contrast from erroring out when non-RGB color spaces are used.
Closes: #4080