refactor: add util function to normalize node argument#3998
Merged
Conversation
WilcoFiers
previously requested changes
May 2, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Had some ideas, but we should probably discuss before you make changes.
lib/commons/aria/arialabel-text.js
Outdated
Comment on lines
+10
to
+11
| export default function arialabelText(element) { | ||
| const { vNode } = normalizeNode(element); |
Contributor
There was a problem hiding this comment.
Bummer decorators aren't available yet. I'd love to have this work:
Suggested change
| export default function arialabelText(element) { | |
| const { vNode } = normalizeNode(element); | |
| @nodeLookup | |
| export default function arialabelText({ vNode }) { |
WilcoFiers
approved these changes
May 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for #3896 I decided that instead of needing to import two different things (
AbstractVirtualNodeandgetNodeFromTree) and copying and pasting the same if statement, we should instead have a helper function that does the things for us. So that's what I did.