Conversation
WilcoFiers
reviewed
Apr 6, 2023
| ]); | ||
| const builder = new AxeBuilder(driver, axeSource) | ||
| // Support table has no title and has duplicate ids | ||
| .exclude('#at-support') |
Contributor
There was a problem hiding this comment.
Yikes! Fair enough though.
WilcoFiers
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apg tests weren't running due to the github repo completely changing structure in w3c/aria-practices#2417. I updated the paths to the new structure and was able to remove a lot of the skipped rules for specific pages as well. I also set the tags to only run wcag21aa and below so we don't get best practice rules or aaa rules running.
Lastly, I wanted to pin the repo to their lastest release, but they changed the structure after that release so instead just pinned to the latest commit (as it would be a lot of spaghetti code to try to maintain two directory structures for the test).