Skip to content

chore(i18n): Add missing Japanese rules translations#3941

Merged
straker merged 16 commits intodequelabs:developfrom
shunito:i18n-ja-translate
Apr 6, 2023
Merged

chore(i18n): Add missing Japanese rules translations#3941
straker merged 16 commits intodequelabs:developfrom
shunito:i18n-ja-translate

Conversation

@shunito
Copy link
Copy Markdown
Contributor

@shunito shunito commented Mar 12, 2023

Added translations of Japanese rules that are missing due to recent updates.

@shunito shunito requested a review from a team as a code owner March 12, 2023 04:32
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 12, 2023

CLA assistant check
All committers have signed the CLA.

@shunito shunito changed the title Add missing Japanese rules translations chore(i18n): Add missing Japanese rules translations Mar 12, 2023
@straker
Copy link
Copy Markdown
Contributor

straker commented Mar 13, 2023

Thanks for the pr. We'll need to look for someone who speaks Japanese that can review this, so might be a bit. But we'll make sure to get it merged.

locales/ja.json Outdated
},
"focusable-not-tabbable": {
"pass": "要素内にフォーカス不可能な要素は含まれていません",
"incomplete": "Check if the focusable elements immediately move the focus indicator",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation is not finished..

@shunito
Copy link
Copy Markdown
Contributor Author

shunito commented Mar 14, 2023

I found a section that has not been translated yet.
I will add them within a few days.

shunito added 3 commits March 15, 2023 21:01
tabindexを「マイナス」という表現を元の翻訳と合わせ「負」に変更
letter-spacing = 文字の間隔
word-spacing = 単語の間隔
@shunito
Copy link
Copy Markdown
Contributor Author

shunito commented Mar 15, 2023

@straker Thank you for your usual contributions.
I have added the missing translated text.
and, I have then asked the member who created the original Japanese translation to review it.

@ma10
Copy link
Copy Markdown
Contributor

ma10 commented Mar 16, 2023

Maybe @kiyochika could review?

shunito added 6 commits March 20, 2023 00:04
tabindexを「マイナス」という表現を元の翻訳と合わせ「負」に変更
letter-spacing = 文字の間隔
word-spacing = 単語の間隔
@shunito shunito force-pushed the i18n-ja-translate branch from a534489 to fb9c985 Compare March 19, 2023 15:04
@straker
Copy link
Copy Markdown
Contributor

straker commented Apr 6, 2023

Thanks for the translations. Approved for security.

@straker straker merged commit 13aa1f8 into dequelabs:develop Apr 6, 2023
@shunito shunito deleted the i18n-ja-translate branch April 7, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants