fix(color-contrast): do not check contrast for inert elements#3894
Merged
fix(color-contrast): do not check contrast for inert elements#3894
Conversation
WilcoFiers
approved these changes
Jan 26, 2023
Contributor
Author
|
We determined not to worry about inert inputs and their labels for now. If someone brings up an issue about it we'll reconsider. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the work on supporting inert. One question I have is if we want to not check the color contrast of labels (implicit, explicit, etc.) for inputs that are inerted. So this example:
We prevent checking this type of setup if the input is disabled (or
aria-disabled). Do we need to do the same if the input hasinert?Closes: #3448