Skip to content

fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color#3791

Merged
WilcoFiers merged 5 commits intodevelopfrom
text-stroke
Nov 28, 2022
Merged

fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color#3791
WilcoFiers merged 5 commits intodevelopfrom
text-stroke

Conversation

@WilcoFiers
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers commented Nov 21, 2022

Consider -webkit-text-stroke and its cousin -webkit-text-fill-color when calculating contrast

Closes #3356

@WilcoFiers WilcoFiers marked this pull request as ready for review November 22, 2022 11:09
@WilcoFiers WilcoFiers requested a review from a team as a code owner November 22, 2022 11:09
@WilcoFiers WilcoFiers requested a review from straker November 22, 2022 11:09
@WilcoFiers WilcoFiers changed the title fix(color-contrast): use text-stroke colors fix(color-contrast): use -webkit-text-stroke colors Nov 22, 2022
@WilcoFiers WilcoFiers changed the title fix(color-contrast): use -webkit-text-stroke colors fix(color-contrast): consider -webkit-text-stroke & -webkit-text-fill-color Nov 22, 2022
Copy link
Copy Markdown
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, rest looks good

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-webkit-text-stroke- vs "insufficient contrast"

2 participants