feat(checks/label-content-name-mismatch): deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo#3782
feat(checks/label-content-name-mismatch): deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo#3782straker merged 7 commits intodequelabs:developfrom nolandanley:develop
Conversation
|
|
| */ | ||
| function shouldIgnoreIconLigature(virtualNode, context) { | ||
| const { ignoreIconLigature, pixelThreshold, occuranceThreshold } = context; | ||
| const { ignoreIconLigature, pixelThreshold, occurrenceThreshold } = context; |
There was a problem hiding this comment.
This should avoid a break in the API.
| const { ignoreIconLigature, pixelThreshold, occurrenceThreshold } = context; | |
| const { ignoreIconLigature, pixelThreshold } = context; | |
| const occurrenceThreshold = context.occurrenceThreshold ?? context.occurenceThreshold |
There was a problem hiding this comment.
Thanks for this! I think you mean "occuranceThreshold" since that was the only version of the typo used in code. "Occurence" was only used in a comment. Added this modified fix in 22d9b95a1d851fae3c850f0a5f125a4ba8bf0438.
…lcoFiers' suggestions.
straker
left a comment
There was a problem hiding this comment.
Thanks, looking good so far, just need to update the name in one more place. Also, since we're going to deprecate the old name we'll need to update the pr title to match conventional commits. We deprecate things as a feat and want to make sure the title says which thing is deprecated, and either the pr title or body should say what to use instead.
straker
left a comment
There was a problem hiding this comment.
Everything looks great. Looks like the tests are failing due to missing optional chaining. Tests should pass once it's added.
|
Reviewed for security |
Fixes typos of the word "occurrence" throughout axe-core.