fix(create-grid): include elements scrolled out of view in the grid#3773
Merged
WilcoFiers merged 14 commits intodevelopfrom Nov 14, 2022
Merged
fix(create-grid): include elements scrolled out of view in the grid#3773WilcoFiers merged 14 commits intodevelopfrom
WilcoFiers merged 14 commits intodevelopfrom
Conversation
straker
requested changes
Nov 9, 2022
WilcoFiers
commented
Nov 10, 2022
Comment on lines
+46
to
+47
| '<div id="n0" style="position: fixed; top:-31px; height: 60px">0</div>' + | ||
| '<div id="n1" style="position: fixed; top:-31px; height: 30px">1</div>' + |
Contributor
Author
There was a problem hiding this comment.
Found a weird bug around isOffScreen. Something with bottom:0 is considered on screen. Changing that caused a bunch of other problems. Need to look into that, but seems like a separate issue.
WilcoFiers
commented
Nov 10, 2022
lib/commons/dom/create-grid.js
Outdated
Comment on lines
+386
to
+388
| if (debug) { | ||
| console.log({ x, y }, { rowIndex, colIndex }, { top, right, bottom, left }); | ||
| } |
straker
previously requested changes
Nov 10, 2022
straker
previously approved these changes
Nov 14, 2022
lib/commons/dom/create-grid.js
Outdated
| 'Element midpoint exceeds the grid bounds' | ||
| ); | ||
| const row = this.cells[rowIndex - this.cells._negativeIndex] ?? []; | ||
| return row[colIndex - row._negativeIndex] ?? null; |
Contributor
There was a problem hiding this comment.
Small thing. Maybe this should return an empty array instead of null? That way when you use it in get-rect-stack we wouldn't need to do default it to an empty array using || [] after the call?
straker
approved these changes
Nov 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue: #3772