Skip to content

chore: release axe-core 4.5.0 (sri-history corrected)#3744

Merged
WilcoFiers merged 1 commit intomasterfrom
release-fix-4.5.0
Oct 24, 2022
Merged

chore: release axe-core 4.5.0 (sri-history corrected)#3744
WilcoFiers merged 1 commit intomasterfrom
release-fix-4.5.0

Conversation

@WilcoFiers
Copy link
Copy Markdown
Contributor

Had an issue with sri-history.json because we did the release a bit out of order.

@WilcoFiers WilcoFiers requested a review from a team as a code owner October 24, 2022 16:15
@WilcoFiers WilcoFiers changed the title chore: correct 4.5.0 sri-history.json chore: release axe-core 4.5.0 (sri-history corrected) Oct 24, 2022
Copy link
Copy Markdown
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but won't this break things if the SRI is bad in 4.5.0?

@WilcoFiers
Copy link
Copy Markdown
Contributor Author

@stephenmathieson No, the SRI was incorrect because we changed source after we created the sri-history file. We forgot to update it. This is the update.

@WilcoFiers WilcoFiers merged commit ebff028 into master Oct 24, 2022
@WilcoFiers WilcoFiers deleted the release-fix-4.5.0 branch October 24, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants