ci: fix chrome integration tests and split browser tests#3735
Merged
ci: fix chrome integration tests and split browser tests#3735
Conversation
straker
commented
Oct 20, 2022
| console.log(); | ||
| console.log(err.message); | ||
| console.log('Aborted testing using ' + options.browser); | ||
| return process.exit(); |
Contributor
Author
There was a problem hiding this comment.
Catching the error caused the silent failure so removed it
stephenmathieson
approved these changes
Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that our Chrome integration tests were silently failing due to
setDefaultServicenot being a function anymore in selenium-webdriver 4.3.1+. Fixed the issue by using the new way to create drivers and also split the firefox and chrome tests while I was at it.Since we're not running safari or mobile-chrome, I also removed the code logic for those since they won't work with the new way of creating drivers. Will have to add those back in when we re-enable those browsers in separate pr.
Closes issue: #3653