refactor(empty-table-header): use virtual node#3621
Merged
Conversation
use virtual node references: #3473
6 tasks
This test uses the role of rowheader in order to bypass all the additional setup, as this attribute skips parent/children logic
straker
previously requested changes
Aug 26, 2022
Contributor
There was a problem hiding this comment.
We'll also want to add a test in test/commons/table/get-scope.js that verifies auto is returned if passed an element without an actualNode or in the tree.
WilcoFiers
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use virtual node
references: #3473