Skip to content

chore(release): 4.4.1#3377

Merged
WilcoFiers merged 7 commits intomasterfrom
release-4.4.1
Feb 4, 2022
Merged

chore(release): 4.4.1#3377
WilcoFiers merged 7 commits intomasterfrom
release-4.4.1

Conversation

@straker
Copy link
Copy Markdown
Contributor

@straker straker commented Feb 3, 2022

No description provided.

@straker straker requested a review from a team as a code owner February 3, 2022 18:03
@WilcoFiers WilcoFiers force-pushed the release-4.4.1 branch 2 times, most recently from 131fff1 to ffc7f11 Compare February 4, 2022 09:51
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Audit

I did notice one of my commit messages had a typo, due to which it didn't follow the commit policy. I manually added it to the changelog.

@dylanb
Copy link
Copy Markdown
Contributor

dylanb commented Feb 4, 2022

reviewed

@WilcoFiers one commit had a typo in the semantic commit message - why do we not use the robot to check those?

@WilcoFiers WilcoFiers merged commit f583c70 into master Feb 4, 2022
@WilcoFiers WilcoFiers deleted the release-4.4.1 branch February 4, 2022 15:00
@WilcoFiers
Copy link
Copy Markdown
Contributor

@dylanb I think it went wrong in the commit message box in GitHub itself. There are no bots that run there. Still though. A GH action that checks the PR title is a good idea. Michael used it in one of our repos. Need to expand it to more of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants