fix(aria-allowed-role): allow combobox on button, checkbox and combobox on input[type=button]#3354
Merged
straker merged 5 commits intodequelabs:developfrom Nov 29, 2022
Merged
Conversation
closes dequelabs#3353 - Adds `role=combobox` to the `<button>` element. - Adds `role=combobox` and `role=checkbox` to the `<input type=button>` element.
WilcoFiers
previously requested changes
Jan 17, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
We'll need integration tests for aria-allowed-role.
* `button role=combobox` * `input type=button role=combobox` * `input type=button role=checkbox`
Contributor
|
We seem to have let this pr fall into the cracks. Going to update it a bit to make sure it's ready for review again. |
WilcoFiers
approved these changes
Nov 28, 2022
Contributor
|
[x] Reviewed for security |
This was referenced Dec 5, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #3353
role=comboboxto the<button>element.role=comboboxandrole=checkboxto the<input type=button>element.