Closed
Conversation
WilcoFiers
requested changes
Jul 16, 2021
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
aria-orientation should not be allowed on audio elements. We should fix this instead of ignoring the problem.
Contributor
Author
|
We've decided to remove the role checking of aria-allowed-attr instead of removing the test, but to do so in a feat as it will introduce new failures that haven't been flagged before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will start blocking any pr to develop as the failed example 2 does not fail in axe-core.
The reason is that the
audioelement does not have an implicit role (see also https://www.w3.org/TR/html-aam-1.0/#details-id-8), and as such our aria-allowed-attr check does not check allowed attrs for roleless elements.Once this is merged, I will create a tech debt ticket for it similar to #2960