-
Notifications
You must be signed in to change notification settings - Fork 881
isFocusable is too strict on tabindex #4632
Copy link
Copy link
Closed
Labels
coreIssues in the core code (lib/core)Issues in the core code (lib/core)fixBug fixesBug fixesgood first issueFor first-time contributorsFor first-time contributors
Description
The way axe-core checks whether tabindex is valid is by calling parseInt(). That's different from how HTMLhttps://html.spec.whatwg.org/#rules-for-parsing-integers says to do it. Basically, axe should use this to match, and then parseInt the captured group: /^\s*([-+]?\d+)/
The issue is here: lib/commons/dom/is-focusable.js
The tests for it need to be here: test/commons/dom/is-focusable.js
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
coreIssues in the core code (lib/core)Issues in the core code (lib/core)fixBug fixesBug fixesgood first issueFor first-time contributorsFor first-time contributors