Skip to content

fix: Add LICENSE-3RD-PARTY.txt file#4304

Merged
WilcoFiers merged 6 commits intodevelopfrom
3rd-party-license
Feb 1, 2024
Merged

fix: Add LICENSE-3RD-PARTY.txt file#4304
WilcoFiers merged 6 commits intodevelopfrom
3rd-party-license

Conversation

@WilcoFiers
Copy link
Copy Markdown
Contributor

@WilcoFiers WilcoFiers commented Jan 22, 2024

Axe-core needs to include the copyright and licenses of third-party software.

I also looked at preserving the copyright statements from third-party libraries where they are embedded. Unfortunately that will require us addressing the webpack issue due to which we pinned our ESBuild version. #4305

@WilcoFiers WilcoFiers requested a review from a team as a code owner January 22, 2024 12:24
Copy link
Copy Markdown
Contributor

@keith-rhodes-0723 keith-rhodes-0723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it has correct info.



-----------------------------------------------------------------------------
The MIT License (MIT)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memoizee isn't MIT. The text in here is accurate but the section title is off.

Suggested change
The MIT License (MIT)
ISC License

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I think we'd be tool-generating these files rather than hand-authoring them, to avoid the possibility of this sort of mistake, but I can live with deferring that til a later proposal/PR separate from getting this in place as a stopgap.

-----------------------------------------------------------------------------
The MIT License (MIT)
Applies to:
- core-js-pure; Copyright (c) 2014-2023 Denis Pushkarev
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these copyright statements will need to be updated when we update the versions of these dependencies. For the purposes of this PR getting something in place, I think we can tolerate "needing to remember that when we review dependabot PRs", but I think ideally longer-term that would probably be "a github action that detects when PRs modify the lockfile and regenerates this text file accordingly".

Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
@WilcoFiers WilcoFiers merged commit daa0fe6 into develop Feb 1, 2024
@WilcoFiers WilcoFiers deleted the 3rd-party-license branch February 1, 2024 10:42
straker pushed a commit that referenced this pull request Feb 5, 2024
Axe-core needs to include the copyright and licenses of third-party
software.

I also looked at preserving the copyright statements from third-party
libraries where they are embedded. Unfortunately that will require us
addressing the webpack issue due to which we pinned our ESBuild version.
#4305

---------

Co-authored-by: Dan Bjorge <dan.bjorge@deque.com>
WilcoFiers added a commit that referenced this pull request Mar 25, 2024
##
[4.9.0](v4.8.4...v4.9.0)
(2024-03-25)

### Features

- adding the wcag131 tag to the aria-hidden-body rule
([#4349](#4349))
([dd4c3c3](dd4c3c3)),
closes [#4315](#4315)
- **checks:** deprecate aria-busy check
([#4356](#4356))
([be0b555](be0b555)),
closes [#4347](#4347)
[#4340](#4340)
- **color:** add color channel values and luminosity, saturation, clip
functions ([#4366](#4366))
([9e70199](9e70199)),
closes
[/github.com//pull/4365/files#r1517706612](https://github.com/dequelabs//github.com/dequelabs/axe-core/pull/4365/files/issues/r1517706612)
- **i18n:** add Greek Translations
([#3836](#3836))
([3ea9a48](3ea9a48))
- **i18n:** Add Italian translation
([#4344](#4344))
([de1baa9](de1baa9))
- **i18n:** Add Simplified Chinese translation
([#4379](#4379))
([bda7c8d](bda7c8d))
- **i18n:** Add Taiwanese Mandarin translation
([#4299](#4299))
([c5e11de](c5e11de))

### Bug Fixes

- Add LICENSE-3RD-PARTY.txt file
([#4304](#4304))
([daa0fe6](daa0fe6))
- add Object.values polyfill for node <=6
([#4274](#4274))
([5eb867b](5eb867b))
- **aria-required-children:** avoid confusing aria-busy message in
failures ([#4347](#4347))
([591607d](591607d)),
closes [#fail13](https://github.com/dequelabs/axe-core/issues/fail13)
[#4340](#4340)
- avoid reading element-specific node properties of non-element node
types ([#4317](#4317))
([b853b18](b853b18)),
closes [#4316](#4316)
[#4316](#4316)
- **color-contrast:** handle text that is outside `overflow: hidden`
ancestor ([#4357](#4357))
([bdb7300](bdb7300)),
closes [#4253](#4253)
- **color-contrast:** support color blend modes hue, saturation, color,
luminosity ([#4365](#4365))
([7ae4761](7ae4761))
- **d.ts:** RawNodesResult issues
([#4229](#4229))
([d660518](d660518))
- **d.ts:** RunOptions.reporter can be any string
([#4218](#4218))
([e53f5c5](e53f5c5))
- **i18n:** update Italian translations
([#4377](#4377))
([4d65d4b](4d65d4b))
- **listitem:** clarify roleNotValid message
([#4374](#4374))
([0f8a9af](0f8a9af))
- **scrollable-region-focusable:** missing wcag213 tag
([#4201](#4201))
([0080a72](0080a72))
- **target-size:** always pass 10x targets (avoid perf bottleneck)
([#4376](#4376))
([be327c4](be327c4))
- **target-size:** do not crash for nodes with many overlapping widgets
([#4373](#4373))
([1dbea83](1dbea83)),
closes [#4359](#4359)
[#4359](#4359)
[#4360](#4360)
- **utils/get-selector:** ignore 'xmlns' attribute when generating a
selector ([#4303](#4303))
([938b411](938b411))

This PR was opened by a robot 🤖 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants