fix(color-contrast): ignore format unicode characters#4102
Merged
Conversation
WilcoFiers
previously approved these changes
Jul 26, 2023
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
I'm okay with this approach, but had an idea you might appreciate.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Contributor
Author
|
Thanks. I do indeed like the idea much better |
WilcoFiers
approved these changes
Jul 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format characters such as zero-width spaces were not checked in the
nonBMPsection of the unicode functions. I generated the regex by using regenerate and adding all format unicode to it.In making this change I also discovered a bug in
hasUnicodein that it only checked the first option that matched and not all options due to the early return style. So trying to check if a string contained punctuation while also checking if it had emoji would only ever check if it had emoji. Fixed that while I was here.Closes: #3913