fix(aria-allowed-role): add meter to allowed roles for named img#4055
Merged
straker merged 5 commits intodequelabs:developfrom Jun 16, 2023
Merged
fix(aria-allowed-role): add meter to allowed roles for named img#4055straker merged 5 commits intodequelabs:developfrom
straker merged 5 commits intodequelabs:developfrom
Conversation
4 tasks
straker
requested changes
Jun 15, 2023
Contributor
There was a problem hiding this comment.
Thanks for the pr. Would you be able to add a test for this is test/integration/aria-allowed-role.html. Just adding an image tag with the new role and an id that will need to be added to the companion json file pass section.
Contributor
Author
|
added |
Contributor
|
Thanks. The element will need an |
scottaohara
commented
Jun 16, 2023
test/integration/rules/aria-allowed-role/aria-allowed-role.html
Outdated
Show resolved
Hide resolved
straker
approved these changes
Jun 16, 2023
Contributor
straker
left a comment
There was a problem hiding this comment.
Awesome! Thanks for doing that.
Reviewed for security.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4054
as stated in the PR title, this adds the meter element to be an allowed role for the img element when it is provided an accessible name.