fix(aria-required-children): set related nodes for invalid children#4033
Merged
WilcoFiers merged 1 commit intodevelopfrom May 24, 2023
Merged
fix(aria-required-children): set related nodes for invalid children#4033WilcoFiers merged 1 commit intodevelopfrom
WilcoFiers merged 1 commit intodevelopfrom
Conversation
straker
approved these changes
May 23, 2023
| true, | ||
| fixture.querySelector('b'), | ||
| 'hello world', | ||
| new axe.SerialVirtualNode({ |
Contributor
There was a problem hiding this comment.
I'm glad you added this one. At first I thought it would go through so nice to see it in a test to ensure it doesn't.
This was referenced May 24, 2023
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure virtual nodes are accepted as related nodes. This prevented aria-required-children from reporting related nodes. I would've added a test to
aria-required-childrenfor related nodes, but it turned out it already has them. We just never noticed it wasn't working.Closes: #4032