Skip to content

fix(is-icon-ligature): prevent canvas2d warning willReadFrequently#3931

Merged
straker merged 1 commit intodequelabs:developfrom
Rrroman:canvas2d-warning
Mar 6, 2023
Merged

fix(is-icon-ligature): prevent canvas2d warning willReadFrequently#3931
straker merged 1 commit intodequelabs:developfrom
Rrroman:canvas2d-warning

Conversation

@Rrroman
Copy link
Copy Markdown
Contributor

@Rrroman Rrroman commented Mar 4, 2023

Removes the console warning related to font-icon checking and improves the speed of multiple readback operations, as mentioned in the warning.

Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: https://html.spec.whatwg.org/multipage/canvas.html#concept-canvas-will-read-frequently

Closes: 3900

@Rrroman Rrroman requested a review from a team as a code owner March 4, 2023 16:08
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 4, 2023

CLA assistant check
All committers have signed the CLA.

@straker
Copy link
Copy Markdown
Contributor

straker commented Mar 6, 2023

Thanks for the pr! Approved for security

@straker straker changed the title fix(is-icon-ligature): canvas2d warning fix(is-icon-ligature): prevent canvas2d warning willReadFrequently Mar 6, 2023
@straker straker merged commit b3c52bb into dequelabs:develop Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font icon detection results in Canvas2D warning

3 participants