Conversation
…o parent Closes issue: #3788
WilcoFiers
requested changes
Dec 1, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
LGTM, although it'd be good to add a couple more tests to prove this out.
| @@ -1,17 +1,61 @@ | |||
| describe('empty-table-header virtual-rule', function () { | |||
| it('should incomplete when children are missing', function () { | |||
| it('should fail when children contain no visible text', function () { | |||
Contributor
There was a problem hiding this comment.
Can you add a couple more tests:
With empty content:
- it passes when the table has role=none
- it passes when the th has role=cell
Contributor
Author
There was a problem hiding this comment.
it passes when the table has role=none
Steve said that the following test needs to be a new ticket as it is not a related issue. He was going to chat with you today about it I think.
This test currently fails:
it('should pass with a table of role none', function () {
var table = new axe.SerialVirtualNode({
nodeName: 'table',
attributes: {
role: 'none'
}
});
var tr = new axe.SerialVirtualNode({
nodeName: 'tr',
});
var th = new axe.SerialVirtualNode({
nodeName: 'th',
});
tr.children = [th];
tr.parent = table;
th.parent = tr;
th.children = [];
table.children = [tr];
var results = axe.runVirtualRule('empty-table-header', table);
assert.lengthOf(results.passes, 1);
assert.lengthOf(results.violations, 0);
assert.lengthOf(results.incomplete, 0);
});
it passes when the th has role=cell
Test has been added and passes.
…eader-virtualised-rule-should-run-without-requiring-role
WilcoFiers
approved these changes
Dec 6, 2022
Contributor
WilcoFiers
left a comment
There was a problem hiding this comment.
Please open that follow-up issue on table[role=none].
Contributor
Author
|
Issue added, #3817 |
This was referenced Dec 9, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue: #3788