-
Notifications
You must be signed in to change notification settings - Fork 885
Link-in-text-block problems #3774
Copy link
Copy link
Closed
Labels
fixBug fixesBug fixesprA pr has been created for the issueA pr has been created for the issuerule metadataIssues in the rule metadata code (lib/rules)Issues in the rule metadata code (lib/rules)rulesIssue or false result from an axe-core ruleIssue or false result from an axe-core rule
Metadata
Metadata
Assignees
Labels
fixBug fixesBug fixesprA pr has been created for the issueA pr has been created for the issuerule metadataIssues in the rule metadata code (lib/rules)Issues in the rule metadata code (lib/rules)rulesIssue or false result from an axe-core ruleIssue or false result from an axe-core rule
Type
Fields
Give feedbackNo fields configured for issues without a type.
The recent changes to link-in-text-block rule has a few problems. First, the
datais not converting the colors into hex, so the failureSummary is using[Object object]instead of the hex color. Also, the contrast is not being truncated so the contrast is very long decimal number.Lastly, the issue is reporting false positives for the following HTML:
The matches function uses
textContentto determine if the link has text, buttextContextgrabs the text of the style element so it passes the matches.