Skip to content

Commit 9f1a3e3

Browse files
WilcoFiersWilcoFiers
authored
feat(duplicate-id-aria): set to review on fail and tag as wcag412 (#4075)
1 parent 55000d0 commit 9f1a3e3

5 files changed

Lines changed: 13 additions & 7 deletions

File tree

‎doc/rule-descriptions.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
| [definition-list](https://dequeuniversity.com/rules/axe/4.7/definition-list?application=RuleDescription) | Ensures <dl> elements are structured correctly | Serious | cat.structure, wcag2a, wcag131, EN-301-549, EN-9.1.3.1 | failure | |
3838
| [dlitem](https://dequeuniversity.com/rules/axe/4.7/dlitem?application=RuleDescription) | Ensures <dt> and <dd> elements are contained by a <dl> | Serious | cat.structure, wcag2a, wcag131, EN-301-549, EN-9.1.3.1 | failure | |
3939
| [document-title](https://dequeuniversity.com/rules/axe/4.7/document-title?application=RuleDescription) | Ensures each HTML document contains a non-empty <title> element | Serious | cat.text-alternatives, wcag2a, wcag242, TTv5, TT12.a, EN-301-549, EN-9.2.4.2, ACT | failure | [2779a5](https://act-rules.github.io/rules/2779a5) |
40-
| [duplicate-id-aria](https://dequeuniversity.com/rules/axe/4.7/duplicate-id-aria?application=RuleDescription) | Ensures every id attribute value used in ARIA and in labels is unique | Critical | cat.parsing, wcag2a, wcag411, EN-301-549, EN-9.4.1.1 | failure | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) |
40+
| [duplicate-id-aria](https://dequeuniversity.com/rules/axe/4.7/duplicate-id-aria?application=RuleDescription) | Ensures every id attribute value used in ARIA and in labels is unique | Critical | cat.parsing, wcag2a, wcag412, EN-301-549, EN-9.4.1.2 | needs review | [3ea0c8](https://act-rules.github.io/rules/3ea0c8) |
4141
| [form-field-multiple-labels](https://dequeuniversity.com/rules/axe/4.7/form-field-multiple-labels?application=RuleDescription) | Ensures form field does not have multiple label elements | Moderate | cat.forms, wcag2a, wcag332, TTv5, TT5.c, EN-301-549, EN-9.3.3.2 | needs review | |
4242
| [frame-focusable-content](https://dequeuniversity.com/rules/axe/4.7/frame-focusable-content?application=RuleDescription) | Ensures <frame> and <iframe> elements with focusable content do not have tabindex=-1 | Serious | cat.keyboard, wcag2a, wcag211, TTv5, TT4.a, EN-301-549, EN-9.2.1.1 | failure, needs review | [akn7bn](https://act-rules.github.io/rules/akn7bn) |
4343
| [frame-title-unique](https://dequeuniversity.com/rules/axe/4.7/frame-title-unique?application=RuleDescription) | Ensures <iframe> and <frame> elements contain a unique title attribute | Serious | cat.text-alternatives, wcag2a, wcag412, TTv5, TT12.d, EN-301-549, EN-9.4.1.2 | needs review | [4b1c6c](https://act-rules.github.io/rules/4b1c6c) |

‎lib/rules/duplicate-id-aria.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
"selector": "[id]",
44
"matches": "duplicate-id-aria-matches",
55
"excludeHidden": false,
6-
"tags": ["cat.parsing", "wcag2a", "wcag411", "EN-301-549", "EN-9.4.1.1"],
6+
"tags": ["cat.parsing", "wcag2a", "wcag412", "EN-301-549", "EN-9.4.1.2"],
7+
"reviewOnFail": true,
78
"actIds": ["3ea0c8"],
89
"metadata": {
910
"description": "Ensures every id attribute value used in ARIA and in labels is unique",

‎test/integration/rules/duplicate-id-aria/duplicate-id-aria.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
<select id="ignore4"></select>
99
<div tabindex="0" id="ignore5"></div>
1010

11-
<span id="fail1" class="fail1"></span>
12-
<button id="fail1"></button>
11+
<span id="incomplete1" class="incomplete1"></span>
12+
<button id="incomplete1"></button>
1313
<span id="pass1"></span>
1414
<button id="pass2"></button>
15-
<div aria-labelledby="fail1 pass1 pass2"></div>
15+
<div aria-labelledby="incomplete1 pass1 pass2"></div>
1616

1717
<input id="ignore6" type="hidden" />
1818
<button id="ignore7" disabled></button>

‎test/integration/rules/duplicate-id-aria/duplicate-id-aria.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"description": "duplicate-id-aria test",
33
"rule": "duplicate-id-aria",
4-
"violations": [[".fail1"]],
4+
"violations": [],
5+
"incomplete": [[".incomplete1"]],
56
"passes": [["#pass1"], ["#pass2"]]
67
}

‎test/integration/rules/runner.js‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@
9595
// check that all nodes are removed
9696
assert.equal(JSON.stringify(targets), '[]');
9797
} else {
98-
assert(false, 'there are no ' + collection);
98+
assert.lengthOf(
99+
test[collection],
100+
0,
101+
'there are no ' + collection
102+
);
99103
}
100104
});
101105
});

0 commit comments

Comments
 (0)