Skip to content

Commit 11fad59

Browse files
marktnoonanmarktnoonan
authored
fix: correct typos in texts (#4499)
Hi! I noticed some minor typos and inconsistent text capitalization, as well as what looks like flipped `help` and `description` text in one spot for the `landmark-unique` rule. This PR fixes the ones I was able to spot. I noticed some overlap with #4385, I'd be happy to grab the text changes mentioned there in this PR as well, ("Ensures" -> "Ensure" in rule descriptions), if that's not stepping on anybody's toes.
1 parent 3ef9353 commit 11fad59

12 files changed

Lines changed: 34 additions & 34 deletions

‎doc/rule-descriptions.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@
8686

8787
These rules are disabled by default, until WCAG 2.2 is more widely adopted and required.
8888

89-
| Rule ID | Description | Impact | Tags | Issue Type | ACT Rules |
90-
| :----------------------------------------------------------------------------------------------- | :------------------------------------------------- | :------ | :--------------------------------------------- | :------------------------- | :-------- |
91-
| [target-size](https://dequeuniversity.com/rules/axe/4.9/target-size?application=RuleDescription) | Ensure touch target have sufficient size and space | Serious | cat.sensory-and-visual-cues, wcag22aa, wcag258 | failure, needs review | |
89+
| Rule ID | Description | Impact | Tags | Issue Type | ACT Rules |
90+
| :----------------------------------------------------------------------------------------------- | :-------------------------------------------------- | :------ | :--------------------------------------------- | :------------------------- | :-------- |
91+
| [target-size](https://dequeuniversity.com/rules/axe/4.9/target-size?application=RuleDescription) | Ensure touch targets have sufficient size and space | Serious | cat.sensory-and-visual-cues, wcag22aa, wcag258 | failure, needs review | |
9292

9393
## Best Practices Rules
9494

@@ -115,7 +115,7 @@ Rules that do not necessarily conform to WCAG success criterion but are industry
115115
| [landmark-no-duplicate-contentinfo](https://dequeuniversity.com/rules/axe/4.9/landmark-no-duplicate-contentinfo?application=RuleDescription) | Ensures the document has at most one contentinfo landmark | Moderate | cat.semantics, best-practice | failure | |
116116
| [landmark-no-duplicate-main](https://dequeuniversity.com/rules/axe/4.9/landmark-no-duplicate-main?application=RuleDescription) | Ensures the document has at most one main landmark | Moderate | cat.semantics, best-practice | failure | |
117117
| [landmark-one-main](https://dequeuniversity.com/rules/axe/4.9/landmark-one-main?application=RuleDescription) | Ensures the document has a main landmark | Moderate | cat.semantics, best-practice | failure | |
118-
| [landmark-unique](https://dequeuniversity.com/rules/axe/4.9/landmark-unique?application=RuleDescription) | Landmarks should have a unique role or role/label/title (i.e. accessible name) combination | Moderate | cat.semantics, best-practice | failure | |
118+
| [landmark-unique](https://dequeuniversity.com/rules/axe/4.9/landmark-unique?application=RuleDescription) | Ensures landmarks are unique | Moderate | cat.semantics, best-practice | failure | |
119119
| [meta-viewport-large](https://dequeuniversity.com/rules/axe/4.9/meta-viewport-large?application=RuleDescription) | Ensures <meta name="viewport"> can scale a significant amount | Minor | cat.sensory-and-visual-cues, best-practice | failure | |
120120
| [page-has-heading-one](https://dequeuniversity.com/rules/axe/4.9/page-has-heading-one?application=RuleDescription) | Ensure that the page, or at least one of its frames contains a level-one heading | Moderate | cat.semantics, best-practice | failure | |
121121
| [presentation-role-conflict](https://dequeuniversity.com/rules/axe/4.9/presentation-role-conflict?application=RuleDescription) | Elements marked as presentational should not have global ARIA or tabindex to ensure all screen readers ignore them | Minor | cat.aria, best-practice, ACT | failure | [46ca7f](https://act-rules.github.io/rules/46ca7f) |

‎lib/checks/aria/aria-errormessage.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@
1111
"hidden": "aria-errormessage value `${data.values}` cannot reference a hidden element"
1212
},
1313
"incomplete": {
14-
"singular": "ensure aria-errormessage value `${data.values}` references an existing element",
15-
"plural": "ensure aria-errormessage values `${data.values}` reference existing elements",
16-
"idrefs": "unable to determine if aria-errormessage element exists on the page: ${data.values}"
14+
"singular": "Ensure aria-errormessage value `${data.values}` references an existing element",
15+
"plural": "Ensure aria-errormessage values `${data.values}` reference existing elements",
16+
"idrefs": "Unable to determine if aria-errormessage element exists on the page: ${data.values}"
1717
}
1818
}
1919
}

‎lib/checks/forms/autocomplete-appropriate.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"impact": "serious",
77
"messages": {
8-
"pass": "the autocomplete value is on an appropriate element",
9-
"fail": "the autocomplete value is inappropriate for this type of input"
8+
"pass": "The autocomplete value is on an appropriate element",
9+
"fail": "The autocomplete value is inappropriate for this type of input"
1010
}
1111
}
1212
}

‎lib/checks/forms/autocomplete-valid.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"metadata": {
55
"impact": "serious",
66
"messages": {
7-
"pass": "the autocomplete attribute is correctly formatted",
8-
"fail": "the autocomplete attribute is incorrectly formatted"
7+
"pass": "The autocomplete attribute is correctly formatted",
8+
"fail": "The autocomplete attribute is incorrectly formatted"
99
}
1010
},
1111
"options": {

‎lib/checks/shared/aria-labelledby.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"messages": {
77
"pass": "aria-labelledby attribute exists and references elements that are visible to screen readers",
88
"fail": "aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty",
9-
"incomplete": "ensure aria-labelledby references an existing element"
9+
"incomplete": "Ensure aria-labelledby references an existing element"
1010
}
1111
}
1212
}

‎lib/checks/shared/presentational-role.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"metadata": {
55
"impact": "minor",
66
"messages": {
7-
"pass": "Element's default semantics were overriden with role=\"${data.role}\"",
7+
"pass": "Element's default semantics were overridden with role=\"${data.role}\"",
88
"fail": {
99
"default": "Element's default semantics were not overridden with role=\"none\" or role=\"presentation\"",
1010
"globalAria": "Element's role is not presentational because it has a global ARIA attribute",

‎lib/checks/shared/role-none.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"metadata": {
1313
"impact": "minor",
1414
"messages": {
15-
"pass": "Element's default semantics were overriden with role=\"none\"",
15+
"pass": "Element's default semantics were overridden with role=\"none\"",
1616
"fail": "Element's default semantics were not overridden with role=\"none\""
1717
}
1818
}

‎lib/checks/shared/role-presentation.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"metadata": {
1313
"impact": "minor",
1414
"messages": {
15-
"pass": "Element's default semantics were overriden with role=\"presentation\"",
15+
"pass": "Element's default semantics were overridden with role=\"presentation\"",
1616
"fail": "Element's default semantics were not overridden with role=\"presentation\""
1717
}
1818
}

‎lib/rules/landmark-unique.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"selector": "[role=banner], [role=complementary], [role=contentinfo], [role=main], [role=navigation], [role=region], [role=search], [role=form], form, footer, header, aside, main, nav, section",
55
"tags": ["cat.semantics", "best-practice"],
66
"metadata": {
7-
"help": "Ensures landmarks are unique",
8-
"description": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination"
7+
"description": "Ensures landmarks are unique",
8+
"help": "Landmarks should have a unique role or role/label/title (i.e. accessible name) combination"
99
},
1010
"matches": "landmark-unique-matches",
1111
"all": [],

‎lib/rules/table-duplicate-name.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"tags": ["cat.tables", "best-practice"],
66
"metadata": {
77
"description": "Ensure the <caption> element does not contain the same text as the summary attribute",
8-
"help": "tables should not have the same summary and caption"
8+
"help": "Tables should not have the same summary and caption"
99
},
1010
"all": [],
1111
"any": [],

0 commit comments

Comments
 (0)