Support phpstan/phpdoc-parser v1 along with v2#1517
Merged
Conversation
patrickkusebauch
approved these changes
Nov 14, 2025
patrickkusebauch
left a comment
Collaborator
There was a problem hiding this comment.
I would recommend to pull this logic into a utility function somewhere, so that you don't have to repeat yourself so many times, as the code is the same in all instances.
Frankly, this should have been done already even before your change.
651d63e to
bf8a4a6
Compare
patrickkusebauch
approved these changes
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for v1 was removed #1494.
Because deptrac is a utility tool and is not supposed to introduce compatibility issues with application packages, I suggest temporarily retaining support for phpstan/phpdoc-parser v1. This approach was taken in Symfony, and I believe it is a good solution symfony/type-info@51535dd
Partially resolves #1505.