Expand the scope of ignored PHP-Doc tags#1516
Merged
gennadigennadigennadi merged 2 commits intoDec 1, 2025
Merged
Conversation
Closes: deptrac#1399 Expand the list of tags that produce placeholder names that should be ignored by Deptrac from `@template` to also include `@template-covariant`, `@phpstan-type` and `@phpstan-import-type`. This is coincidentally only necessary for Nikic Parser and not PHPStan parser. That does it out of the box. Also, this is a whack-a-mole, as the list of these types of tags can expand in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1399
Expand the list of tags that produce placeholder names that should be ignored by Deptrac from
@templateto also include@template-covariant,@phpstan-typeand@phpstan-import-type.This is coincidentally only necessary for Nikic Parser and not PHPStan parser. That does it out of the box. Also, this is a whack-a-mole, as the list of these types of tags can expand in the future.