Revert "Open SF deps for v8"#1514
Merged
Merged
Conversation
This reverts commit 94ee640.
patrickkusebauch
approved these changes
Nov 1, 2025
Contributor
|
@gennadigennadigennadi Deptrac not allowing Symfony 8 component currently blocks me from testing some of my applications with Symfony 8 before the release. I'd be happy to help making Deptrac ready but I would first need to understand what exactly broke with #1512. What would I have to look for if I wanted to continue the work being started? |
Collaborator
Author
|
@xabbuh symfony 7.4 deprecates and removes with symfony 8.0 the configbuilder. deptracs php config depends on those classes. In theory, we could still open the dependencies but we would break deptrac.php configs, deptrac.yaml would probably still work. see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1512
https://github.com/symfony/symfony/pull/62113/files breaks our php config :-(