merge deptrac src#1471
Conversation
84c24fe to
97e874b
Compare
97e874b to
82572d8
Compare
|
I will be happy to help. Pretty busy on Thursday, but rest of the week I shall find time to take a look. The more info you can provide into what are your expectations from me, the better. |
|
Are you looking for documentation as to how to "scope" deptrac using |
Exactly. What do you think about dropping the composer.lock and widen the Symfony dependencies? This would help reduce the conflict potential with project dependencies. |
|
What I foresee the impact of dropping
What do I think about widening Symfony dependencies:
|
|
We could just put this into the Note If you experience Composer conflicts while installing Deptrac, we recommend to "scope" the Deptrac installation using the excellent bamarni/composer-bin-plugin. It allows you to install Deptrac and all its dependencies to a separate "scoped" folder where it cannot have any conflicts with currently installed dependencies. Deptrac has been tested and works well with this workflow. If needed, I can write a blog post going into excruciating step-by-step details, and we can just add a link to that in the note. But I would not block this PR on this. |
patrickkusebauch
left a comment
There was a problem hiding this comment.
Too large, did not check line by line, but overall looks good.
Pulled the branch and explored a little, ran the make commands and Deptrac itself, all looked good.
A blog post would be awesome. My concern is with the current deptrac dependencies (e.g. symfomy ^6) But this should not be a blocker. |
|
Blog post PR here: #1474 |
Combine deptrac-src and deptrac, aka get ride of the scoped approach.
This should make the deptrac-src repo obsolete, but it still misses an updated documentation how to install a not-scoped deptrac. @patrickkusebauch do you think you could help out if that?