feat: ArtifactoryAnalyzer updated to use the HTTPClient5-based Downloader and skip unusable results#7293
Merged
jeremylong merged 3 commits intomainfrom Jan 25, 2025
Merged
Conversation
…eset of DependencyCheck Also mitigate issue #5868 by skipping (with a warning log) unusable results instead of throwing an exception so that multi-result responses can be handled.
Collaborator
Author
|
Marked as a draft PR awaiting results from the community on live-testing a snapshot build against an Artifactory Pro instance. |
…that turns out to have runtime platform differences
…of detail Resolves the NPE reported in jeremylong/DependencyCheck#7254 (comment) Logs a warning for each entry in the response that does not have the checksums block that is to be expected for any request that has the `X-Result-Detail: info` HTTP header.
jeremylong
approved these changes
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Make ArtifactoryAnalyzer use the Downloader class to finalize the migration of HTTP-traffic to use the Apache HTTPClient5 finalizing the work still left after #6949
Make ArtifactoryAnalyzer skip results that do not fit the expectations (matching hashes and a maven-like G/A/V path structure) and attempt to find further matches in the remaining search results instead of throwing an exception on a first unexpected result entry format.
Related issues
Fixes #5868
Fixes #7254
Have test cases been added to cover the new functionality?
yes a testcase was added for the fix of #5868