fix(fp): FP per issue #6138 and #6139#6140
Merged
jeremylong merged 1 commit intodependency-check:generatedSuppressionsfrom Nov 27, 2023
Merged
fix(fp): FP per issue #6138 and #6139#6140jeremylong merged 1 commit intodependency-check:generatedSuppressionsfrom
jeremylong merged 1 commit intodependency-check:generatedSuppressionsfrom
Conversation
chadlwilson
commented
Nov 26, 2023
jeremylong
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The FP automation doesn't work for these Maven Central-stored RubyGems, but seems more sensible to fix these properly since they seem to have started with
9.0.xwhere all specific Ruby Gems are being incorrectly detected as rubygems itself.Merging to the
generatedSuppressionsbranch itself to avoid this needing a "release" - similar to other FP suppressions.Have test cases been added to cover the new functionality?
no