fix reproducible build issues#4302
Merged
Merged
Conversation
jeremylong
approved these changes
Apr 4, 2022
nhumblot
reviewed
Nov 5, 2022
| <excludeProperty>git.build.user.*</excludeProperty> | ||
| <excludeProperty>git.build.host</excludeProperty> | ||
| <excludeProperty>git.commit.user.*</excludeProperty> | ||
| <excludeProperty>git.commit.count</excludeProperty> |
Collaborator
There was a problem hiding this comment.
Should have been git.total.commit.count :)
Contributor
Author
There was a problem hiding this comment.
yes :)
and git.tags also needs to be excluded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
fix reproducible builds issues found when rebuilding 7.0.4 release: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/owasp/dependency-check/dependency-check-parent-7.0.4.diffoscope
there is only 1 unknown issue: why is the
HelpMojo.classnot reproduced? I have no clue yet...at least with this PR, only 1 jar won't be successful
Have test cases been added to cover the new functionality?
no