Conversation
b5ad09d to
1ec131a
Compare
There was a problem hiding this comment.
Pull request overview
Refactors Cloudsmith OIDC credential field names to remove the oidc- prefix (aligning with other OIDC providers), and updates tests/config scaffolding accordingly.
Changes:
- Update Cloudsmith OIDC credential parsing to use
namespace,service-slug, andaudience. - Update OIDC-related tests to use the new Cloudsmith key names.
- Add a standardized PR template and ignore
/tmpat repo root.
Show a summary per file
| File | Description |
|---|---|
internal/oidc/oidc_credential.go |
Switch Cloudsmith OIDC parameter extraction from oidc-* keys to unprefixed keys. |
internal/oidc/oidc_credential_test.go |
Update Cloudsmith credential test fixtures to use the new key names. |
internal/oidc/oidc_registry_test.go |
Update Cloudsmith registry test credential helper to use the new key names. |
internal/handlers/oidc_handling_test.go |
Update end-to-end handler tests to supply Cloudsmith credentials via the new key names. |
.gitignore |
Ignore a root-level /tmp directory. |
.github/pull_request_template.md |
Add a PR template to standardize PR descriptions. |
Copilot's findings
- Files reviewed: 5/6 changed files
- Comments generated: 1
1ec131a to
e91eeb0
Compare
e91eeb0 to
151e245
Compare
brettfo
requested changes
Apr 15, 2026
brettfo
approved these changes
Apr 15, 2026
- Rename oidc-namespace to namespace - Rename oidc-service-slug to service-slug - Rename oidc-audience to audience - Add pull request template Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
151e245 to
0c93db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Refactor CloudSmith OIDC credential field names to remove the
oidc-prefix for consistency with other OIDC providers (Azure, AWS, JFrog).Changes:
oidc-namespace→namespaceoidc-service-slug→service-slugoidc-audience→audienceThis also adds a PR template modeled after dependabot-core to standardize PR descriptions.
Anything you want to highlight for special attention from reviewers?
The credential key names (
namespace,service-slug,audience) are now consistent with how other providers define their OIDC parameters — without a provider-specific prefix. This is a breaking change for any configuration currently using theoidc-prefixed keys, so companion PRs in github/github and github-ui must land together.How will you know you have accomplished your goal?
All existing tests pass with the updated key names, confirming functional equivalence. The companion PRs in github/github and github-ui will update the configuration layer to emit the new key names.
Checklist