Remove skipLibCheck from tsconfig.json#683
Merged
Merged
Conversation
Changes module from "commonjs" to "es2022" and moduleResolution from "node" to "bundler". This tells TypeScript to resolve imports the way esbuild does, including support for package.json "exports" maps used by newer @actions/* and @octokit/* packages. Since esbuild handles the actual CJS output (--format=cjs), these settings only affect type-checking — the runtime behavior is unchanged.
6c4c100 to
0ea234d
Compare
With moduleResolution set to "bundler", TypeScript can properly resolve types through package.json "exports" maps. The skipLibCheck workaround is no longer needed — tsc --noEmit passes cleanly without it.
e484856 to
38c8d66
Compare
truggeri
approved these changes
Mar 26, 2026
This was referenced May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #682.
With
moduleResolutionset to"bundler", TypeScript can properly resolve types throughpackage.json"exports"maps. TheskipLibCheckworkaround added in #676 is no longer needed —tsc --noEmitpasses cleanly without it.All 49 tests pass.