-
Notifications
You must be signed in to change notification settings - Fork 116
Closed
Labels
enhancementNew feature or requestNew feature or request
Description
@yeikel pointed out that we don't need to do the internal check within the action if we recommend on the Readme that users check the user before executing the action:
- Add support for dependabot-script/custom commit users #317 (comment)
- feat: add option to set custom user #331 (comment)
I think this is the reason the check exists within the code... the concern is that users may not realize they need to set that, and so may fire off spurious requests... so it's defensive coding to protect the API from ignorant/careless users.
That said, I agree the volume of calls here is probably pretty low, so it may be fine to remove this... 🤷♂️
Removing it would simplify the code / config complexity since the DEPENDABOT_LOGIN const and associated logic of letting users customize the user simply disappears...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request