Skip to content

Replace deprecated pipenv lock with pipenv requirements#7764

Merged
jeffwidman merged 1 commit intomainfrom
switch-from-lock-command-to-requirements-command
Aug 8, 2023
Merged

Replace deprecated pipenv lock with pipenv requirements#7764
jeffwidman merged 1 commit intomainfrom
switch-from-lock-command-to-requirements-command

Conversation

@jeffwidman
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman commented Aug 8, 2023

In the versions between what we are currently on in dependaobt-core and the latest versions of pipenv, they deprecated and then completely removed the pipenv lock [-d] command in favor of pipenv requirements [--dev] command.

Since our current version of pipenv supports the pipenv requirements command, let's proactively switch to it now. That will make the future upgrade in #7715 easier.

More context:

@jeffwidman jeffwidman requested a review from a team as a code owner August 8, 2023 18:40
@jeffwidman jeffwidman force-pushed the switch-from-lock-command-to-requirements-command branch from 9485c02 to dcc729c Compare August 8, 2023 18:44
@jeffwidman
Replace deprecated pipenv lock with pipenv requirements
5a57cbf 
In the versions between what we are currently on in `dependaobt-core`
and the latest versions of `pipenv`, they deprecated and then completely
removed the `pipenv lock [-d]` command in favor of `pipenv requirements
[--dev]` command.

Since our current version of `pipenv` supports the `pipenv requirements`
command, let's proactively switch to it now. That will make the future
upgrade in #7715
easier.

More context:
* pypa/pipenv#5069
* pypa/pipenv#5091
* pypa/pipenv#5198
* pypa/pipenv#5200
@jeffwidman jeffwidman force-pushed the switch-from-lock-command-to-requirements-command branch from dcc729c to 5a57cbf Compare August 8, 2023 18:45
@jeffwidman jeffwidman self-assigned this Aug 8, 2023
@jeffwidman jeffwidman added Ecosystems Used by the maintainer team for internal-facing project tracking L: python:pipenv Python packages via pipenv labels Aug 8, 2023
@jeffwidman
Copy link
Copy Markdown
Member Author

jeffwidman commented Aug 8, 2023 •
edited
Loading

BTW @matteius it was a little painful to track this down.

I'm all for deprecations and even removing functionality, but maybe leave the deprecation message around a little longer?

Our current version is less than two years old and in that time it was deprecated, but then the warning was also removed... would have been nicer if pipenv lock -r became a no-op with a warning message for another 12-18 months so that I didn't struggle trying to figure out if there was a replacement command or if the functionality was completely removed.

The other way this is typically done is with SemVer where I can look at the major version release notes to see the breaking changes. But that wasn't possible since pipenv is using CalVer.

Just a suggestion.

@jeffwidman jeffwidman enabled auto-merge (squash) August 8, 2023 18:54
@jeffwidman jeffwidman merged commit 460dcf6 into main Aug 8, 2023
@jeffwidman jeffwidman deleted the switch-from-lock-command-to-requirements-command branch August 8, 2023 19:18
@matteius
Copy link
Copy Markdown

matteius commented Aug 8, 2023

Thanks for the feedback @jeffwidman -- I think that is a reasonable request we can try to accommodate going forward. CC @oz123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@honeyankit honeyankit honeyankit approved these changes

Assignees

@jeffwidman jeffwidman

Labels

Ecosystems Used by the maintainer team for internal-facing project tracking L: python:pipenv Python packages via pipenv L: python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeffwidman @matteius @honeyankit