Skip to content

bug: fresh islands are broken with preact 1.22.1 #2587

@JOTSR

Description

@JOTSR

Fresh island rendering is broken in preact 1.22.1

Bug

children.js:123 Uncaught (in promise) TypeError: n2.contains is not a function
    at S (children.js:123:16)
    at O (index.js:246:4)
    at S (children.js:85:3)
    at O (index.js:246:4)
    at B (render.js:37:2)
    at _render (main.ts:109:7)

image

It seems that fresh root fragments of islands are missing contains method.

Bug reason

The PR replace isConnected with parentDom.contains #4421 breaks fresh island rendering with new contains method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions