feat: ensure source maps are cached#628
Merged
fraidev merged 2 commits intodenoland:mainfrom Nov 26, 2025
Merged
Conversation
|
|
bc0af36 to
1e21984
Compare
1e21984 to
0fc04f3
Compare
2 tasks
bartlomieju
reviewed
Nov 24, 2025
Member
bartlomieju
left a comment
There was a problem hiding this comment.
This looks good from my side, but I'll defer for David to approve
dsherret
approved these changes
Nov 25, 2025
Contributor
dsherret
left a comment
There was a problem hiding this comment.
Nice! Looks good to me once a test is added for the serialization/deserialization.
| pub jsdoc_imports: Vec<JsDocImportInfo>, | ||
| /// Source map URL extracted from sourceMappingURL comment | ||
| #[serde(skip_serializing_if = "Option::is_none", default)] | ||
| pub source_map_url: Option<SpecifierWithRange>, |
Contributor
There was a problem hiding this comment.
Can you add a serialization/deserialization test for this? We need to ensure it's somewhat stable.
Contributor
Author
There was a problem hiding this comment.
Sure, I added a test in my last commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for: denoland/deno#31268