fix: include Temporal types in deno types output#32952
Merged
bartlomieju merged 1 commit intodenoland:mainfrom Mar 25, 2026
Merged
fix: include Temporal types in deno types output#32952bartlomieju merged 1 commit intodenoland:mainfrom
bartlomieju merged 1 commit intodenoland:mainfrom
Conversation
Add "esnext.temporal" to the lib_names list in get_types_declaration_file_text() so that `deno types` emits the Temporal namespace declarations from TypeScript's lib.esnext.temporal.d.ts. This was accidentally removed in denoland#32656 (typescript-go update) which dropped the "deno.temporal" entry added by denoland#32571. Since deno types does flat concatenation (doesn't follow /// <reference> chains), the Temporal types were silently lost from the output. Closes denoland#32950 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
"esnext.temporal"to thelib_nameslist inget_types_declaration_file_text()so thatdeno typesemits the Temporal namespace declarations from TypeScript'slib.esnext.temporal.d.ts.This was accidentally removed in #32656 (typescript-go update) which dropped the
"deno.temporal"entry added by #32571. Sincedeno typesdoes flat concatenation (doesn't follow/// <reference>chains), the Temporal types were silently lost from the output, breaking docs generation at docs.deno.com.Closes #32950
Test plan
🤖 Generated with Claude Code